Repository navigation
Conversation
The platform rejects `branches create` with a 400 when its TLS connection drops while setting the branch database password. Treat that rejection like the 57P01 restart in the helper's single clear-and-recreate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014y76TaNM2eKGdpmiMQXWqu
|
/ai-review Generated by Claude Code |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Superseded by a newer AI review
🤖 AI Review
Both independent reviews reported no findings. Reading the changed helper and surrounding tests confirms that the TLS failure uses the existing cleanup-and-retry path, retries only once, and preserves subsequent failures. No actionable issues or fundamental conflicts with the supplied next-branch context were found. Tests were not run because dependencies are not installed.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews reported no findings. Reading the changed files and surrounding code confirmed that the TLS failure matcher uses the existing single-retry path, preserves cleanup, and propagates a second failure. The regression test covers the new error message. No actionable issues or fundamental next-branch conflicts found. Tests were not run because dependencies are absent.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: manual · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
TL;DR
The live branch helper now re-creates a branch once when the platform drops TLS while setting the branch password, the same way it handles a 57P01 database restart.
apps/cli/src/commands/branches/get/get.live.test.ts › gets a preview branch by name:branches createfailed with400: Failed to update password: Client network socket disconnected before secure TLS connection was established. This is a transient platform rejection during create, like the 57P01 restart from test(cli): fix 1 flaky test in live branch create #7256, but the helper only re-issued the create for 57P01. The helper's transient-rejection matcher now also covers this documented TLS drop, so it runs the same single clear-and-recreate. A second rejection still fails.create.liveuses the same helper and gets the fix too.ref
spotted in:
Generated by Claude Code