Skip to content

fix(parser): reject invalid packet types #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taigrr merged 1 commit into from
Aug 22, 2026
Merged

fix(parser): reject invalid packet types #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@ func (d *decoder) Decode(v *packet) error {
if err != nil {
return err
}
if t < '0' || t > '0'+byte(BinaryAck) {
return fmt.Errorf("invalid packet type %q", t)
}
v.Type = packetType(t - '0')

if v.Type == BinaryEvent || v.Type == BinaryAck {
Expand Down
18 changes: 18 additions & 0 deletions parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,24 @@ func TestPacketType(t *testing.T) {
})
}

func TestDecodeRejectsInvalidPacketType(t *testing.T) {
for _, input := range []string{"/", "7", "9[]"} {
t.Run(input, func(t *testing.T) {
saver := &FrameSaver{
data: []FrameData{{
Buffer: bytes.NewBufferString(input),
Type: engineio.MessageText,
}},
}

var p packet
if err := newDecoder(saver).Decode(&p); err == nil {
t.Fatalf("Decode(%q) error = nil, want invalid packet type error", input)
}
})
}
}

func TestParser(t *testing.T) {
p := packet{}
var decodeData any
Expand Down