fix: return 409 instead of 502 when a pushed action fails - #201
Merged
Conversation
paragmore
changed the title
Work-order and spare-part handlers responded with 502 when a pushed action came back with errors, but Cloudflare replaces origin 502 bodies with its own error page, so the ERR_ reason (for example ERR_NO_AVAILABLE_IP when the subnet has no free lease) never reached the client. These are failures reported by the workers for a request that conflicts with the current system state, so return 409 with the ERR_ message intact.
paragmore
force-pushed
the
fix/action-failure-status
branch
from
August 26, 2026 11:27
8cb98cb to
7746299
Compare
paragmore
changed the title
tekwani
approved these changes
Aug 26, 2026
shrutesh-tether
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work-order and spare-part handlers set statusCode 502 when a pushed action returned errors. Cloudflare replaces origin 502 responses with its own error page, so the actual ERR_ message — e.g. ERR_NO_AVAILABLE_IP when a work order's replacement miner can't get a lease — never reached the client; curl and the UI only saw a generic origin_bad_gateway error.
These failures are reported by the workers for a request that conflicts with the current system state, so they now return 409 with the ERR_ message intact, which Cloudflare passes through unchanged. 502 stays reserved for actual gateway problems.
Related unit suites pass (the finance.handlers test failure is pre-existing on develop).