Skip to content

fix: return 409 instead of 502 when a pushed action fails #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paragmore merged 1 commit into from
Aug 26, 2026
Merged

fix: return 409 instead of 502 when a pushed action fails #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workers/lib/server/handlers/spare.parts.handlers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ async function updateSparePart (ctx, req) {
const partPushErrors = _pushErrors(partResults)
if (partPushErrors.length) {
const err = new Error(`ERR_PART_UPDATE_PUSH_FAILED:${partPushErrors.join(',')}`)
err.statusCode = 502
err.statusCode = 409
err.detail = { stage: 'part', partAction: null, workOrderAction: null }
throw err
}
Expand Down
4 changes: 2 additions & 2 deletions workers/lib/server/lib/work.orders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function assertActionApplied (results, errCode) {
const errors = (results || []).flatMap(r => r?.errors || [])
if (errors.length) {
const err = new Error(`${errCode}:${errors.join(',')}`)
err.statusCode = 502
err.statusCode = 409
throw err
}
}
Expand All @@ -69,7 +69,7 @@ async function assertActionsExecuted (ctx, req, errCode) {
.flatMap(target => (target.calls || []).map(call => call.error).filter(Boolean)))
if (!errors.length) return
const err = new Error(`${errCode}:${errors.join(',')}`)
err.statusCode = 502
err.statusCode = 409
throw err
}

Expand Down
Loading