Repository navigation
Conversation
shish
marked this pull request as draft
October 24, 2026 12:23
shish
force-pushed
the
push-xzrrplkxnosn
branch
from
October 24, 2026 12:45
ffdba3e to
eec1d11
Compare
I fear that this is going to have a lot of false-positives (eg cases where phpstan's custom types library adds extra context which doesn't exist natively), but let's try it and see...
shish
force-pushed
the
push-xzrrplkxnosn
branch
from
October 24, 2026 14:06
eec1d11 to
ef1109e
Compare
Collaborator
Author
|
Yup, that sure is a lot of false-positives :( I like the idea, but it's going to need quite a bit of work to get the multiple sources of truth in-sync... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fear that this is going to have a lot of false-positives (eg cases
where phpstan's custom types library adds extra context which doesn't
exist natively), but let's try it and see...