Repository navigation
[1.0.x] Handle malformed Unicode in generated avatars - #137
Merged
Merged
Conversation
(cherry picked from commit 974c486) Signed-off-by: NipuniBhagya <nipunib@wso2.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the
 |
🔀 Cross-SDK feature parity, no ports neededThis pull request is labelled |
NipuniBhagya
force-pushed
the
1.0.x-fixes
branch
from
October 26, 2026 15:18
0fea56f to
2809306
Compare
Fixes GHSA-cg2g-xh64-v4q7 (critical), GHSA-mrv2-3pqr-j5jr (high) and lower severity DOMPurify advisories. @thunderid/react and @thunderid/vue pin dompurify exactly via the catalog, so 1.0.x releases would otherwise ship a vulnerable version. Matches the version already on main. Signed-off-by: NipuniBhagya <nipunib@wso2.com>
Makes `pnpm audit --audit-level=high` pass on the 1.0.x maintenance branch. - Raise the existing body-parser, brace-expansion, sharp and shell-quote pins to main's versions, add main's devalue and source-map-js overrides, and port its justified audit ignores (node-forge, simple-git). - Pin launch-editor, vite 6/7/8, proxy-addr, seroval, undici 7/8, vue and zod to their patched releases. Main picked most of these up through lockfile refreshes; here they are pinned so the lockfile doesn't drift. - Bump packages/nextjs's `next` devDependency to 15.5.28 (as on main) and the Next.js samples' floor to ^15.5.28. All of these reach the workspace through devDependencies, the samples or the E2E suite, so they don't change what the published SDKs install. Signed-off-by: NipuniBhagya <nipunib@wso2.com>
NipuniBhagya
force-pushed
the
1.0.x-fixes
branch
from
October 26, 2026 15:19
2809306 to
4512588
Compare
ThaminduDilshan
approved these changes
Oct 26, 2026
4 of 13 tasks
senthalan
pushed a commit
to thunder-id/thunderid
that referenced
this pull request
Oct 27, 2026
Bump @thunderid/react and @thunderid/react-router to 1.0.9 to pick up the SDK fix from thunder-id/javascript-sdks#137.
darshanasbg
pushed a commit
to thunder-id/thunderid
that referenced
this pull request
Oct 28, 2026
Bump @thunderid/react and @thunderid/react-router to 1.0.9 to pick up the SDK fix from thunder-id/javascript-sdks#137. Signed-off-by: NipuniBhagya <nipunib@wso2.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Backports the fix for malformed Unicode in generated avatars (#113) to the
1.0.xmaintenance branch.Approach
Cherry-picks
974c486from #113 unchanged withgit cherry-pick -x. The original author is kept. The change touches only@thunderid/browser:generateAvatarDataUri.tsand its test.When releasing, publish
@thunderid/browsertogether with the SDKs that depend on it (react, vue and the framework SDKs built on them), so their users get the fixed browser version.Related Issues
Related PRs
main)Checklist
@thunderid/browserbuilds on this branch andgenerateAvatarDataUri.test.tspasses (27 tests).breaking changelabel added.parity/prs-raisedorparity/prs-not-neededadded.parity/prs-raised, the port links are posted as a reply on the parity check's comment.Security checks
🤖 Generated with Claude Code