Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements PM-6343 by reading Salesforce’s saved “Bookings By Stage” report dynamically for the Sales UI and WIN. No Salesforce records or report definitions are modified, and no report data is stored in the database.
GET /v6/reports/salesfor Administrator/Talent Manager users andGET /v6/reports/win/salesexclusively for M2M tokens withreports:sales.SALES.md.Validation:
pnpm lint,pnpm build, and all 24 Sales tests pass. A read-only live Salesforce check returned all 124 records and 15 columns; Stage filtering and amount sorting passed. The full existing suite has 20 SFDC failures, reproduced unchanged on basedevelop(cb9c0f7); the failing suites aresfdc-reports.dto.spec.tsandsfdc-reports.service.spec.ts.Deployment: inject Salesforce credentials from secure server configuration and grant the new
reports:salesscope to the WIN machine client. Companion UI: topcoder-platform/platform-ui#2303Dev validation: deployed image
reports-api-v6:382returns all 124 records and 15 columns. Live API checks passed for Admin/Talent Manager access, rejection of ordinary users, dedicated WIN machine scope, rejection ofreports:allalone and human WIN access, pagination, Stage filtering, amount sorting and invalid-query handling. Salesforce credentials are injected through dev SSM SecureString parameters. The Sales preview is https://sales.topcoder-dev.com.