Repository navigation
feat(rules): MCPCFG-004 unscoped MCP credential and MCPCFG-005 plain-http remote MCP server (schema 38) - #284
Merged
Conversation
…http remote MCP server (schema 38)
ivanpaghubasan
requested review from
ericksondelacruz,
jhumel-code and
sairenchristianbuerano
October 28, 2026 13:45
sairenchristianbuerano
approved these changes
Oct 28, 2026
ivanpaghubasan
marked this pull request as ready for review
October 28, 2026 13:49
This was referenced Oct 28, 2026
feat(rules): add MCPCFG-004 and MCPCFG-005 to mcp_client_config
trustabl/agent-reliability-rules#208
Merged
…l-scope-remote-auth # Conflicts: # CHANGELOG.md # CLAUDE.md # COVERAGE.md # internal/analysis/project_config_test.go # internal/rules/schema_version.go # internal/scanner/scanner_test.go # testdata/rules-fixture/manifest.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two repo-scope rules over committed MCP client config, using the existing
MCPCFG-002/003 parse:
options its own docs or source offer. Four cases: github-mcp-server (binary or
ghcr.io image) with GITHUB_PERSONAL_ACCESS_TOKEN and no read-only/toolset option;
the deprecated @modelcontextprotocol/server-github with that token; Supabase MCP
with neither --read-only nor --project-ref; an env key containing SERVICE_ROLE.
localhost, 127.0.0.0/8 or ::1 (RFC 6750 §5.3: bearer tokens require TLS).
Changes
repo_mcp_config_unscoped_credentialandrepo_mcp_config_remote_plain_http; classifiers ininternal/analysis/mcp_client_scope.go.
reduced to a boolean (strconv.ParseBool, as the server binds them) and never stored.
A planted fake token is asserted absent from facts, reasons and JSON.
Not built
The "no credentials" half of the proposal (Claude Code, Cursor, Gemini CLI and Codex
document OAuth sign-in with nothing in the file), remote GitHub/Supabase scope
settings, ADMIN/ROOT/_SUPERUSER env names, GITHUB_TOKEN, Codex env_vars forwarding,
Windsurf serverUrl.
Verification
Related
Rules: trustabl/agent-reliability-rules#208
Rulebook: trustabl/trustabl-rulebook#159
Merge order: engine, rules, rulebook; the rules PR waits for the rulebook PR.