Repository navigation
Speak the usual way during calls rather than through low-latency audio - #190
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With low-latency audio on, Backtalk fell back from the selected text-to-speech engine to Google Speech Services when a call started in Aira. The call's audio mode (
MODE_IN_COMMUNICATION) is set before its microphone recording starts, so the microphone check did not catch it. The engines then said nothing about the first speech after the audio mode changed, the hang check atENGINE_HANG_MS(3 s) counted them as hung, and Backtalk switched engines twice in 5 s. The reporter's logcat shows the two engine switches at those times. It does not contain Backtalk's own "said nothing … hung" line, so this cause is inferred from timing.MODE_IN_CALLorMODE_IN_COMMUNICATION.Limitations: