Skip to content

feat(stovepipe): dlq controller for build step - #618

Open
mnoah1 wants to merge 3 commits into
mainfrom
mnoah1/stovepipe-build-dlq
Open

feat(stovepipe): dlq controller for build step#618
mnoah1 wants to merge 3 commits into
mainfrom
mnoah1/stovepipe-build-dlq

Conversation

@mnoah1

@mnoah1 mnoah1 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Intent

  • Prevent build-stage failures from leaving requests processing and consuming queue capacity indefinitely.

Changes

  • Add a build-stage DLQ controller that resolves the request from the dead-lettered build payload and drives it to a conservative failed outcome.
  • Follow the established SubmitQueue DLQ controller naming and construction conventions.
  • Register the build DLQ topic, subscription, and controller with the always-retryable reconciliation consumer.
  • Cover successful reconciliation, malformed payloads, and empty request identifiers.

Test Plan

  • aifx verify
  • ./tool/bazel test //stovepipe/controller/dlq:go_default_test --test_output=errors
  • ./tool/bazel build //service/stovepipe/server:stovepipe
  • make lint
  • make check-gazelle

Revert Plan

  • Revert this PR to remove build-stage DLQ reconciliation and its topic registration.

Issues

Summary:
Intent:
- Prevent build-stage failures from leaving requests processing and consuming queue capacity indefinitely.

Changes:
- Add a build-stage DLQ controller that resolves the request from the dead-lettered build payload and drives it to a conservative failed outcome.
- Register the build DLQ topic, subscription, and controller with the always-retryable reconciliation consumer.
- Cover successful reconciliation, malformed payloads, and empty request identifiers.

---

<sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
@mnoah1 mnoah1 changed the title fix(stovepipe): reconcile build dead letters feat(stovepipe): dlq controller for build step Aug 19, 2026
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-build-dlq branch from 8fb3faf to 52c1191 Compare August 19, 2026 18:18
@mnoah1
mnoah1 marked this pull request as ready for review August 19, 2026 18:27
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners August 19, 2026 18:27
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-build-dlq branch from 31b38d4 to 52c1191 Compare August 19, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant