refactor(stovepipe): align DLQ controller conventions - #619
Open
mnoah1 wants to merge 1 commit into
Open
Conversation
Summary: Intent: - Align the existing Stovepipe DLQ controllers with the repository-wide convention used by the parent PR. - Keep the public construction API consistent as additional DLQ stages are added. Changes: - Rename the process and buildsignal constructors to the NewDLQ<Stage>Controller pattern. - Hide controller implementations behind consumer.Controller and derive controller names from their topic keys. - Update service wiring and test fixtures for the new constructors. This PR is stacked on #618, which adds build-stage DLQ reconciliation using the same convention. Test Plan: - Run the Stovepipe DLQ controller test target. - Build the Stovepipe server target. Revert Plan: - Revert this PR to restore the prior Stovepipe DLQ constructor and implementation type names. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
mnoah1
marked this pull request as ready for review
August 19, 2026 18:37
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
August 19, 2026 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
This PR is stacked on #618, which adds build-stage DLQ reconciliation using the same convention.
Test Plan
Revert Plan
Issues