Skip to content

feat: migrate to ES modules - #93

Merged
marco-c merged 1 commit into
web-push-libs:mainfrom
43081j:jg/esm
Nov 6, 2026
Merged

marco-c merged 1 commit into
web-push-libs:mainfrom
43081j:jg/esm

Conversation

@43081j

@43081j 43081j commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

This migrates the syntax to standard ES modules (import/export) and
reworks var to be let/const.

Publishing this means anyone on a Node older than 20, using CommonJS,
will not be able to require(...) it. Older Node can import it fine,
and all modern Node can require or import it either way.

This migrates the syntax to standard ES modules (`import`/`export`) and
reworks `var` to be `let`/`const`.

Publishing this means anyone on a Node older than 20, using CommonJS,
will not be able to `require(...)` it. Older Node can `import` it fine,
and all modern Node can `require` or `import` it either way.

@marco-c marco-c left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marco-c
marco-c merged commit eb4f4c6 into web-push-libs:main Nov 6, 2026
3 checks passed
@43081j
43081j deleted the jg/esm branch November 6, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants