Repository navigation
Conversation
package.json points "types" to types/ece.d.ts, which is generated by tsc and gitignored, so nothing guaranteed it existed when publishing.
The script required the build and twine packages to be installed in the system Python, and failed with "No module named build" otherwise.
The tag was always pushed to "origin", which may be a personal fork, and the version bump commit was never pushed at all. Push both to the remote pointing at web-push-libs (overridable with RELEASE_REMOTE).
Previously a failure (e.g. not being logged in to npm) could happen after the PyPI upload, leaving a half-done release. Now the script verifies up front that the working tree is clean, the tag doesn't exist yet and npm is logged in, and only then bumps the version. Also enable strict mode (set -euo pipefail), quote paths, split the version with read instead of a global IFS change, anchor the pyproject version match and stop leaving "~" backup files behind.
Remove stale dist/ and build/ output, run npm ci, the test suite and npm pack (which builds the TypeScript declarations), and validate the Python distributions with twine check. All of this happens before the first upload, so a local failure can't leave a partially published release. If a check fails after the version bump, the bump is reverted so the release can be retried from a clean tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.