Repository navigation
fix(release): build a tag without the signing team secret - #161
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Xcode Cloud builds for v0.0.21, v0.0.22 and v0.0.23 all failed within a minute of starting, so no TestFlight build has gone out since v0.0.20. The first failing tag is the first one built with the hardened
ci_post_clone.sh(#123), which stops a tag build when the workflow secretMAPP_DEVELOPMENT_TEAMis unset. The v0.0.1 to v0.0.20 builds ran a script that treated the secret as optional.A tag build no longer requires the secret: it writes the team when the workflow sets one and otherwise lets Xcode Cloud sign with its own managed signing. The version checks stay.
Checks
The script was run locally for
v0.0.24-rc1andv0.0.24with no team set (both build 0.0.24). The cause is inferred from the build history and the script diff; the cloud log was not readable from here, so the next tag build confirms it.Review depth: checks only (a tag-build script and its instructions, no app code).