Repository navigation
feat(folders): rename search to query and accept all tiers - #2371
Merged
Merged
Conversation
aicayzer
marked this pull request as ready for review
October 24, 2026 01:59
3 tasks done
aicayzer
commented
Oct 24, 2026
aicayzer
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed with Codex (one round, full effort, since this decides which files a folder writes): no findings. The rename holds at every door (type, /folders, folder.yaml, CLI), an old search key and an unknown tier are refused, and tier: all never deletes or trashes an item that leaves the query. 40 server, 13 Rust and 149 device conformance tests passed in review; Full CI green.
aicayzer
enabled auto-merge (squash)
October 24, 2026 02:28
aicayzer
force-pushed
the
feat/folder-query
branch
from
October 24, 2026 02:40
96aba29 to
064560c
Compare
aicayzer
force-pushed
the
feat/folder-query
branch
from
October 24, 2026 02:51
064560c to
2d8049d
Compare
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename a folder's
searchsetting toqueryacross the server, device, CLI, and Swift binding. A query withtier: allwrites matching eligible library and feed items as files; a new file usesdefaults.tieror falls back tolibrary. Closes #2335.Changes
searchand--searchwithout an alias or migration; reject unknown query tiers.47b64241c, including the same tier shape used by views.Testing
MARFA_NO_KEYCHAINunset and all 29 folder CLI tests.pnpm test:changedtwice. The first run found a stale shipped-shape digest, which was regenerated and verified. The second run passed 4,967 selected tests, all 1,144 whole-tree tests, and the contract/generator lane, but failed the unchanged sign-in keyboard test's immediate autofocus assertion (sign-in.browser.test.ts:152, empty focus instead ofemail). That test passed in the first full run and passed its isolated rerun; no sign-in code changed. This intermittent browser-test failure remains separate from the folder change.Notes for reviewers
Reviewed the whole tree for setting readers and stale names, with particular attention to hydration, single-tier slice refusal, defaults, tier departure, and safe file handover. Corrected the contract qualifications and stale CLI help found in review. This is a breaking rename. Full-text search and permanent contract IDs keep their existing names. The Swift change is the Rust binding in this repository; this pull request does not publish an SDK release.
The companion documentation pull request, withmarfa/docs#606, updates the guides and generated references. Leave both pull requests unmerged.
Checklist