Repository navigation
ci: standard concurrency group for CI, License check and Secrets scan - #246
Conversation
… and Secrets scan Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
PetrefiedThunder
left a comment
There was a problem hiding this comment.
REVIEW: PASS muse 159ed0f
- Scope: 3 one-line concurrency.group changes (ci.yml, license-check.yml, secrets.yml) to ${{ github.workflow }}-${{ PR number || ref }}. cancel-in-progress unchanged (pull_request only), so push/merge-queue/schedule/dispatch runs are never cancelled.
- Correctness: workflow names (CI, CodeQL, License check, Lint, Release Python SDK, Secrets scan) are all unique, so dropping the ci-/license-/secrets- prefixes causes no cross-workflow group collision. No triggers, job names or required check names (CI result, License result, gitleaks) change.
- Security: no permissions/secrets/action changes. No made-up data; no code or tests touched.
- Local: all 3 files parse as YAML; ruff check gateway clean (amw-45-rr venv). No Python tests apply.
- CI: all checks green incl. CodeQL, Bugbot, CodeRabbit. 0 unresolved threads. Commit signed off.
PetrefiedThunder
left a comment
There was a problem hiding this comment.
REVIEW: PASS muse 3cb0283
Delta from my PASS at 159ed0f:
- Merge commit 3cb0283 (by Pi) brings in main's e5cbe70 (#247, site-only).
git show --remerge-diffis empty, so no conflict resolutions. - range-diff: 159ed0f is unchanged (1 = 1).
- No .github changes came in from main. The PR's diff against main is still exactly the three one-line concurrency-group changes in ci.yml, license-check.yml and secrets.yml.
- No duplicate workflow
name:values, so the ${{ github.workflow }} groups stay distinct. No other concurrency blocks changed, and no job or required-check names changed. - All workflow YAML parses.
- CI when I posted: lint, gitleaks, licenses, SDK/integration matrices, Vercel and CodeRabbit pass. Gateway 3.11–3.14, Postgres proofs/concurrency, image smoke and CodeQL js/python are still pending. Merge only once those are green.
What this changes
In
ci.yml,license-check.ymlandsecrets.yml, the top-level concurrency group is now the standard one:cancel-in-progresswas already exactly this, so push, merge-queue, schedule and manual runs are still never cancelled. Only the group key changes (the oldci-,license-andsecrets-prefixes are dropped).Path filtering: already in place, no change
Branch protection on
mainrequires CI result, License result and gitleaks, soon.pull_request.pathscannot be used: a filtered-out workflow would never report a required check. Both gated workflows already filter inside the workflow, with gated jobs and analways()result job:detectjob'sfilterstep (pull_request only) skips every heavy job on docs-only PRs and narrows the matrix to changed projects and their dependents. Code, tests, dependency files and workflow changes run.CI resultalways reports.detectjob'sdepsstep (pull_request only) runs the scans only when a dependency manifest, a lockfile, a governing license file or the gate's own config changed.License resultalways reports.Adding
dorny/paths-filterwould duplicate this logic, so I left it out. License files stay in the License check trigger because they decide the outcome of the license gate.Verify
actionlintpasses on all three files.CI result,License result,gitleaks.Note
Low Risk
Workflow-only concurrency grouping changes with no application code or check-name impact.
Overview
Standardizes GitHub Actions concurrency keys on the CI and License check workflows (and the secrets scan workflow per this PR) so they all use the same pattern:
${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}.CI drops the extra
ci-prefix that was prepended before${{ github.workflow }}(which was redundant with the workflow name). License check replaces the customlicense-…group with the workflow-based key.cancel-in-progressis unchanged—still only true forpull_request, so push/merge-queue/schedule/manual runs are not cancelled.Required check names and in-workflow path filtering behavior are untouched; only how concurrent runs of the same workflow are grouped and superseded on PRs changes.
Reviewed by Cursor Bugbot for commit 159ed0f. Bugbot is set up for automated code reviews on this repo. Configure here.