Skip to content

test(spring-boot): [Sample Tests 17] Move the Boot 3 WebFlux sample's tests into the module - #6308

Draft
runningcode wants to merge 2 commits into
no/delete-log4j2-boot-system-testsfrom
no/boot3-webflux-integration-test
Draft

runningcode wants to merge 2 commits into
no/delete-log4j2-boot-system-testsfrom
no/boot3-webflux-integration-test

Conversation

@runningcode

@runningcode runningcode commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

PR Stack (Sample Tests)


📜 Description

Adds an integrationTestWebflux suite to sentry-spring-boot-jakarta. Its classpath has WebFlux but not the servlet stack, so Spring Boot starts a reactive Netty server. It ports these tests from sentry-samples-spring-boot-webflux-jakarta:

  • Person:
    • A failed request reports its error with the feature flag, its http.server transaction, and logs.
    • Creating a person finishes on another thread through a delayed Mono, and is traced and profiled.
  • DistributedTracing: the servlet suite's test, unchanged. Here the app forwards through WebClient.
  • Todo: the WebClient request's http.client span. It calls a local stub instead of the internet.
  • GraphQL: the greeting query, and its resolver error tied to its transaction by trace ID.

The sample's CacheSystemTest and MetricsSystemTest were byte-identical to the servlet ones. They run in this suite too, with cache tracing enabled as the sample had it, so their assertions also hold in the reactive app.

The app builds its own URLs from the incoming request, because a reactive app has no servlet request to read them from. The suite sets sentry.reactive.thread-local-accessor-enabled=true, like the sample.

With no system tests left, the sample comes off the runner, the backend workflow and the Spring Boot 3 matrix. The matrix now runs the new suite, and integrationTests includes it too.

After a coverage audit against the sample's tests:

💡 Motivation and Context

This continues moving the sample system tests into modules, starting the WebFlux flavor with Boot 3.

💚 How did you test it?

  • All 11 tests pass on Spring Boot 3.5.0.
  • They also pass with the catalog set to 3.2.12, the matrix's oldest version.
  • Breaking the Todo span's URL makes that test fail.
  • The slimmed sample still builds.
  • :sentry-spring-boot-jakarta:check passes, and integrationTests now selects the new suite.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

The Boot 4 and Boot 2 WebFlux samples.

#skip-changelog

@sentry

sentry Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.61.0 (1) release

⚙️ sentry-android Build Distribution Settings

This was referenced Oct 20, 2026
runningcode and others added 2 commits October 21, 2026 13:22
…dule

Adds an integrationTestWebflux suite to sentry-spring-boot-jakarta. It
runs a reactive app without the servlet stack, so Spring Boot starts a
WebFlux server, and ports the WebFlux sample's Person,
DistributedTracing, Todo and GraphQL tests. The sample's Cache and
Metrics tests were copies of the servlet ones and don't depend on the
web stack, so the integrationTest suite already covers them.

The WebFlux sample has no system tests left, so it comes off the
system-test runner, the backend workflow and the Spring Boot 3 matrix,
which now runs the new suite. integrationTests includes it too.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ore Cache and Metrics

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@runningcode
runningcode force-pushed the no/boot3-webflux-integration-test branch from 6f7ce55 to e5ffa4d Compare October 21, 2026 11:27
@runningcode
runningcode force-pushed the no/delete-log4j2-boot-system-tests branch from ab05cf1 to ca0c043 Compare October 21, 2026 11:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant