Repository navigation
test(spring-boot): [Sample Tests 17] Move the Boot 3 WebFlux sample's tests into the module - #6308
Draft
runningcode wants to merge 2 commits into
Draft
runningcode wants to merge 2 commits into
runningcode wants to merge 2 commits into
Conversation
Draft
4 of 9 tasks
📲 Install BuildsAndroid
|
This was referenced Oct 20, 2026
Draft
Draft
Draft
This was referenced Oct 20, 2026
Draft
Draft
Draft
Draft
runningcode
force-pushed
the
no/delete-log4j2-boot-system-tests
branch
from
October 21, 2026 09:19
d920038 to
ab05cf1
Compare
runningcode
force-pushed
the
no/boot3-webflux-integration-test
branch
from
October 21, 2026 09:19
ae44ac0 to
6f7ce55
Compare
…dule Adds an integrationTestWebflux suite to sentry-spring-boot-jakarta. It runs a reactive app without the servlet stack, so Spring Boot starts a WebFlux server, and ports the WebFlux sample's Person, DistributedTracing, Todo and GraphQL tests. The sample's Cache and Metrics tests were copies of the servlet ones and don't depend on the web stack, so the integrationTest suite already covers them. The WebFlux sample has no system tests left, so it comes off the system-test runner, the backend workflow and the Spring Boot 3 matrix, which now runs the new suite. integrationTests includes it too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ore Cache and Metrics Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
runningcode
force-pushed
the
no/boot3-webflux-integration-test
branch
from
October 21, 2026 11:27
6f7ce55 to
e5ffa4d
Compare
runningcode
force-pushed
the
no/delete-log4j2-boot-system-tests
branch
from
October 21, 2026 11:27
ab05cf1 to
ca0c043
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Sample Tests)
main)📜 Description
Adds an
integrationTestWebfluxsuite tosentry-spring-boot-jakarta. Its classpath has WebFlux but not the servlet stack, so Spring Boot starts a reactive Netty server. It ports these tests fromsentry-samples-spring-boot-webflux-jakarta:http.servertransaction, and logs.Mono, and is traced and profiled.WebClient.http.clientspan. It calls a local stub instead of the internet.The sample's
CacheSystemTestandMetricsSystemTestwere byte-identical to the servlet ones. They run in this suite too, with cache tracing enabled as the sample had it, so their assertions also hold in the reactive app.The app builds its own URLs from the incoming request, because a reactive app has no servlet request to read them from. The suite sets
sentry.reactive.thread-local-accessor-enabled=true, like the sample.With no system tests left, the sample comes off the runner, the backend workflow and the Spring Boot 3 matrix. The matrix now runs the new suite, and
integrationTestsincludes it too.After a coverage audit against the sample's tests:
sample_randand deferred-sampling tests check the envelope header's trace ID, and a test client built outside the context, as in test(spring-boot): [Sample Tests 7] Move the Boot 3 tracing and HTTP client tests #6293.💡 Motivation and Context
This continues moving the sample system tests into modules, starting the WebFlux flavor with Boot 3.
💚 How did you test it?
:sentry-spring-boot-jakarta:checkpasses, andintegrationTestsnow selects the new suite.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The Boot 4 and Boot 2 WebFlux samples.
#skip-changelog