Repository navigation
test(spring-boot): [Sample Tests 21] Move the Boot 4 OTel no-agent sample's tests - #6313
Draft
runningcode wants to merge 2 commits into
Draft
runningcode wants to merge 2 commits into
runningcode wants to merge 2 commits into
Conversation
…the module Adds an integrationTestOtelNoAgent suite to sentry-spring-boot-4, the Boot 4 counterpart of the Boot 3 one: the app traces through the OpenTelemetry SDK in its own JVM, set up by sentry-opentelemetry-agentless-spring. The sample's tests were the same as the Boot 3 sample's, minus Cache, so the suite is the Boot 3 one with Boot 4's packages and no Cache test. Its Metrics tests were copies of the servlet ones and don't depend on tracing. The sample has no system tests left, so it comes off the system-test runner, the backend workflow and the Spring Boot 4 matrix, which now runs the new suite. integrationTests includes it too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 20, 2026
Draft
Draft
Draft
📲 Install BuildsAndroid
|
This was referenced Oct 20, 2026
Draft
Draft
This was referenced Oct 20, 2026
Draft
Draft
Draft
Draft
…4 no-agent Ports the tracing and GraphQL checks to the Boot 4 OpenTelemetry no-agent suite, and runs the no-agent sample's Metrics tests there too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Sample Tests)
main)📜 Description
Adds an
integrationTestOtelNoAgentsuite tosentry-spring-boot-4, the Boot 4 counterpart of #6312's. It portssentry-samples-spring-boot-4-opentelemetry-noagent's tests, which match the Boot 3 no-agent sample's file for file, except that the Boot 4 sample has no Cache test. So the suite is #6312's, with these changes:RestTemplateBuilderfromspring-boot-restclient;TestRestTemplatefromspring-boot-resttestclient;sentry-spring-7's@SentrySpan.openmodifiers, because the module applies kotlin-spring.integrationTestsuite covers cache tracing.As in #6312, the sample's
MetricsSystemTestruns in this suite too.With no system tests left, the sample comes off the runner, the backend workflow and the Spring Boot 4 matrix. The matrix now runs the new suite, and
integrationTestsincludes it too.After a coverage audit against the sample's tests:
sample_randand deferred-sampling tests check the envelope header's trace ID, and the GraphQL task query'sassigneeIdandcreatorIdchecks from test(spring-boot): [Sample Tests 9] Move the Boot 3 GraphQL tests into the module #6295, and restores the Metrics tests in this suite.💡 Motivation and Context
sentry-opentelemetry-agentless-springbrings in the OpenTelemetry Spring Boot starter, which supports each Boot line separately. The module's build notes that a starter version without Boot 4 support breaks the application context. With the sample's tests gone, this suite is the only check that the starter and Sentry's OTel setup work together on Boot 4. It runs 20 tests.💚 How did you test it?
:sentry-spring-boot-4:checkpasses.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The Boot 2 no-agent sample.
#skip-changelog
🤖 Generated with Claude Code