Repository navigation
test(spring-boot): [Sample Tests 19] Move the Boot 2 WebFlux sample's tests into the module - #6311
Draft
runningcode wants to merge 3 commits into
Draft
runningcode wants to merge 3 commits into
runningcode wants to merge 3 commits into
Conversation
…dule Adds an integrationTestWebflux suite to sentry-spring-boot that mirrors the Boot 3 one, without the Reactor thread-local accessor that Spring Boot 2's Reactor lacks. The GraphQL greeting lives in its own file so the suite can leave it out below Spring Boot 2.7, like the servlet suite's GraphQL. The Boot 2 WebFlux sample has no system tests left, so it comes off the system-test runner, the backend workflow and the Spring Boot 2 matrix, which now runs the new suite. integrationTests includes it too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 20, 2026
Draft
📲 Install BuildsAndroid
|
This was referenced Oct 20, 2026
Draft
Draft
This was referenced Oct 20, 2026
Draft
Draft
Draft
Draft
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ore Metrics Ports the tracing checks and the plain test client from the servlet suite, and runs the WebFlux sample's Metrics tests in the reactive app too, rather than only in the servlet suite. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Sample Tests)
main)📜 Description
Adds an
integrationTestWebfluxsuite tosentry-spring-boot, a copy of the Boot 3 one from #6308. It ports the Boot 2 WebFlux sample's tests (Person, DistributedTracing, Todo, and the GraphQL greeting) and runs them on a reactive Netty server.Changes for Spring Boot 2:
sentry.reactive.thread-local-accessor-enabled, matching the Boot 2 sample. Boot 2's Reactor 3.4 has no automatic context propagation.GreetingController.kt. Below 2.7, the existingbootSupportsGraphqlAndKafkaflag leaves it and the GraphQL test out, as it does for the servlet suite.The sample's Metrics copy runs in this suite too, as in #6308. With no system tests left, the sample comes off the runner, the backend workflow and the Spring Boot 2 matrix, which now runs the new suite.
integrationTestsincludes it too.This finishes the WebFlux flavor: none of the three WebFlux samples has system tests now.
After a coverage audit against the sample's tests:
sample_randand deferred-sampling tests check the envelope header's trace ID, and a test client built outside the context, as in test(spring-boot): [Sample Tests 7] Move the Boot 3 tracing and HTTP client tests #6293, and restores the Metrics tests, as in test(spring-boot): [Sample Tests 17] Move the Boot 3 WebFlux sample's tests into the module #6308.💡 Motivation and Context
This continues moving the sample system tests into their modules, here for the WebFlux flavor on Boot 2.
💚 How did you test it?
:sentry-spring-boot:checkpasses.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The OTel no-agent samples, then the Spring WAR samples.
#skip-changelog