Skip to content

test(spring-boot): [Sample Tests 19] Move the Boot 2 WebFlux sample's tests into the module - #6311

Draft
runningcode wants to merge 3 commits into
no/boot4-webflux-integration-testfrom
no/boot2-webflux-integration-test
Draft

runningcode wants to merge 3 commits into
no/boot4-webflux-integration-testfrom
no/boot2-webflux-integration-test

Conversation

@runningcode

@runningcode runningcode commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

PR Stack (Sample Tests)


📜 Description

Adds an integrationTestWebflux suite to sentry-spring-boot, a copy of the Boot 3 one from #6308. It ports the Boot 2 WebFlux sample's tests (Person, DistributedTracing, Todo, and the GraphQL greeting) and runs them on a reactive Netty server.

Changes for Spring Boot 2:

  • No thread-local accessor: the suite doesn't set sentry.reactive.thread-local-accessor-enabled, matching the Boot 2 sample. Boot 2's Reactor 3.4 has no automatic context propagation.
  • GraphQL needs Spring Boot 2.7: the greeting resolver moves to its own GreetingController.kt. Below 2.7, the existing bootSupportsGraphqlAndKafka flag leaves it and the GraphQL test out, as it does for the servlet suite.

The sample's Metrics copy runs in this suite too, as in #6308. With no system tests left, the sample comes off the runner, the backend workflow and the Spring Boot 2 matrix, which now runs the new suite. integrationTests includes it too.

This finishes the WebFlux flavor: none of the three WebFlux samples has system tests now.

After a coverage audit against the sample's tests:

💡 Motivation and Context

This continues moving the sample system tests into their modules, here for the WebFlux flavor on Boot 2.

💚 How did you test it?

  • All 11 tests pass on Spring Boot 2.7.18, on a Netty server.
  • On 2.4.13, GraphQL drops out and the other 9 tests pass.
  • The slimmed sample still builds.
  • :sentry-spring-boot:check passes.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

The OTel no-agent samples, then the Spring WAR samples.

#skip-changelog

…dule

Adds an integrationTestWebflux suite to sentry-spring-boot that mirrors
the Boot 3 one, without the Reactor thread-local accessor that Spring
Boot 2's Reactor lacks. The GraphQL greeting lives in its own file so
the suite can leave it out below Spring Boot 2.7, like the servlet
suite's GraphQL.

The Boot 2 WebFlux sample has no system tests left, so it comes off the
system-test runner, the backend workflow and the Spring Boot 2 matrix,
which now runs the new suite. integrationTests includes it too.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 20, 2026
@sentry

sentry Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.61.0 (1) release

⚙️ sentry-android Build Distribution Settings

runningcode and others added 2 commits October 20, 2026 20:55
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ore Metrics

Ports the tracing checks and the plain test client from the servlet
suite, and runs the WebFlux sample's Metrics tests in the reactive app
too, rather than only in the servlet suite.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant