Repository navigation
Add OVXR camera panels, G1 feedback cameras and desktop mirror - #8790
Draft
hougantc-nvda wants to merge 4 commits into
Draft
hougantc-nvda wants to merge 4 commits into
hougantc-nvda wants to merge 4 commits into
Conversation
6 of 7 tasks
hougantc-nvda
force-pushed
the
hougantc/kitless-pip-desktop-mirror
branch
from
October 23, 2026 19:25
a0a93cd to
28f136a
Compare
hougantc-nvda
force-pushed
the
hougantc/kitless-pip-desktop-mirror
branch
6 times, most recently
from
October 26, 2026 17:17
33fdb7a to
e480f6f
Compare
This was referenced Oct 26, 2026
hougantc-nvda
force-pushed
the
hougantc/kitless-pip-desktop-mirror
branch
from
October 27, 2026 16:08
f8910f6 to
c342309
Compare
5 tasks done
Signed-off-by: Hougant Chen <hougantc@nvidia.com>
Signed-off-by: Hougant Chen <hougantc@nvidia.com>
Signed-off-by: Hougant Chen <hougantc@nvidia.com>
Signed-off-by: Hougant Chen <hougantc@nvidia.com>
hougantc-nvda
force-pushed
the
hougantc/kitless-pip-desktop-mirror
branch
from
October 29, 2026 02:05
1921fc8 to
1c0382a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Review stack · 4/5: #8787 → #8788 → #8789 → #8790 → #8791
Review only this PR’s changes. The PRs target
main; the comparison isolates this layer from its predecessors.Add optional robot-camera panels (PiP) and a desktop mirror to OVXR teleoperation. Both consume the session's completed images; headset-only operation still needs no desktop window.
isaaclab_teleop: selects camera feeds and supplies configuredCameraPanelConsumerandOwnedDesktopMirrorinstances throughOvxrSessionBinding.frame_consumers.isaaclab_ov: owns camera allocation, scene publication and native resource lifetime through the existing render lease.GR1T2 and G1 locomanipulation expose a robot-view camera; fixed-base G1 adds two wrist feeds. Its camera/image-observation defaults also affect non-XR use; the documented camera-disable option remains available. Kit Scene UI retains its feed settings. SO101 has no declared PiP camera.
The adapter uses a tuple of auxiliary render-product paths for both one and multiple cameras. The mirror uses OVUI's default Vulkan backend. Neither Lab nor Isaac Capture changes
OMNIUI_BACKEND; conflicting initialized backends are rejected. Neither optional consumer is created when disabled.Panels use the existing renderer and a head-locked layout. The mirror shows completed eye or camera images; eye images exclude the separate PiP layers. Closing the mirror requests orderly application shutdown.
PiP/mirror require the matching CUDA 13 package selection. The mirror also requires Python 3.12+, Capture's
desktop-mirrorextra and a usable GPU-backed Vulkan display. See camera panels and desktop mirror for selection and display constraints.Dependencies: compatible Isaac Capture OVXR packages and the provider upgrade in #8858. Native-provider defaults are unchanged.
Type of change
Unsupported panel placements are rejected at the OVXR resolver boundary; the separate Kit Scene UI placements remain supported.
Testing
Results cover the cumulative five-PR stack on main
6ef40d19a6f8d3770f86b5c4df3f8ccfb6a25f95. Kitless checks use Isaac Captureae48621f1cc13054c2246210d8f92d30e27fe354built from source using Python 3.12; Kit checks use Lab's upstream locked Capture selection. They are not independent full-repository results for each PR.Limits: these are synthetic IWER checks, not physical-headset acceptance or full task completion. Cold renderer attach, intermittent GR1T2 first-Play recovery and SO101 cube retention remain open. Kit's upstream dependency selection reports nine metadata inconsistencies, including NumPy/Numba; passing the selected Kit tests does not qualify that entire dependency graph. Full-repository, hosted-CI and arm64 coverage are not claimed.
See #8791 for the matched video-rate measurements.
Checklist
pre-commitchecks withuv run isaaclab --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bump package versions — CI handles that)CONTRIBUTORS.mdor my name already exists thereThe warnings checkbox remains open: dependency warnings and the separate Kit metadata audit are unresolved.