Skip to content

refactor: extract hash operations into HashMixin#804

Draft
oliverhaas wants to merge 2 commits into
jazzband:masterfrom
oliverhaas:refactor/hash-operations-mixin
Draft

refactor: extract hash operations into HashMixin#804
oliverhaas wants to merge 2 commits into
jazzband:masterfrom
oliverhaas:refactor/hash-operations-mixin

Conversation

@oliverhaas

@oliverhaas oliverhaas commented Dec 13, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Dec 13, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.17391% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.3%. Comparing base (e0c234f) to head (657857d).

Files with missing lines Patch % Lines
django_redis/client/mixins/hashes.py 45.0% 3 Missing and 19 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #804     +/-   ##
========================================
+ Coverage    38.2%   38.3%   +0.2%     
========================================
  Files          48      49      +1     
  Lines        3727    3735      +8     
  Branches      301     301             
========================================
+ Hits         1420    1427      +7     
- Misses       2006    2007      +1     
  Partials      301     301             
Flag Coverage Δ
mypy 38.3% <52.2%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@terencehonles

Copy link
Copy Markdown
Contributor

@oliverhaas do you mind sync'ing master? You can probably use the --ours merge conflict resolve strategy and then run pre-commit until it's stable to fix changes due to ruff causing conflicts. That should get you most of the way and then you can look at the diff to see if there are other changes you need to make. Alternatively, and possibly easier, you can just move the methods again.

Once you have done so, can you add a test that runs a diff against the redis.commands.core class you are mirroring and ensure that all methods are implemented (possibly with an exclude/skip list for methods that don't make sense here or maybe need to be implemented later if there are many)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants