[kixelated]

Closes #7267

Summary

• Code backport landed: moq-dev/moq#7290 merged into release on 2026-10-30 as d0cff5ac8b. It ports Audio.Encoder's groupDuration from moq-dev/moq#4910, with the default of 0.
• Published: the maintainer's cut moq-dev/moq#8025 bumped @moq/publish to 0.5.5, and Release JS published it. On 2026-11-06, npm view @moq/publish@0.5.5 version returns 0.5.5, and the packed tarball carries groupDuration (in audio/encoder.d.ts and the encoder bundle).
• This PR deletes the finished quest with quest rm, which also drops its m0 README entry. main is merged in, and quest check --base origin/main passes.

Decisions

• ✅ Decided by the maintainer, 2026-10-30: merge moq-dev/moq#7290 unbumped, and ship it in the maintainer's next combined patch cut. Done as 0.5.5.

Review

Skipped for this head (88f135fb0e). The diff only deletes a finished quest and its README link; quest check --base origin/main validates it. The code's review is recorded on moq-dev/moq#7290 (Codex gpt-6.1-sol, medium effort, head bcd6040fd6: one finding refuted as out of scope, then a clean round).

Follow-ups

• On main, cap audio groups at MAX_GROUP_FRAMES / MAX_GROUP_CACHE_BYTES. A groupDuration of tens of seconds with 2.5 ms Opus frames throws GroupTooLarge. Fix it there, then backport.
• Release coordination: backport quests that target a specific version number can race the release bump. Consider having them name "the next release" instead.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The README no longer lists the “Backport audio groupDuration” quest. The backport plan describing the proposed groupDuration changes and release updates was deleted.

Merge Risk: Minimal · up to 88f13

This cleanup removes the backport plan and its index entry. No actionable merge-blocking risk is identified.

Pre-merge checks: 4 · 1

Failed checks: 1 inconclusive

Check name	Status	Explanation	Resolution
Linked Issues check		[ #7267 ] The PR reports that @moq/publish 0.5.5 contains groupDuration. It deletes the completed quest rather than implementing the behavior. The reviewed head's js/publish/package.json reports versi…	Provide the released 0.5.5 source or artifact and its automated test evidence for groupDuration.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title identifies the deleted backport quest and the reported release.
Description check		The description identifies the deleted quest and its README entry. It also explains the reported release.
Out of Scope Changes check		[#7267] Deleting the completed backport quest and its README entry supports cleanup for the requested publisher release. No unrelated changes appear in the whole-PR summary.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Full details: Linked Issues check

Explanation

[ #7267 ] The PR reports that @moq/publish 0.5.5 contains groupDuration. It deletes the completed quest rather than implementing the behavior. The reviewed head's js/publish/package.json reports version 0.5.2, so it does not establish the contents of the reported release. The available evidence does not independently establish the released implementation or its automated tests.

Resolution

Provide the released 0.5.5 source or artifact and its automated test evidence for groupDuration.

Finishing Touches

Simplify code

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 606bda49-dc8f-43c1-bb10-b2a6bd96ad59

Commits

Reviewing files that changed from the base of the PR and between 1a6ac47 and 88f135f.

Files selected for processing: 2

• quest/m0/README.md
• quest/m0/backport-audio-group-duration.md

Files with no reviewable changes: 1

• quest/m0/backport-audio-group-duration.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

[pullfrog]

✅ No new issues found.

Reviewed changes

• Quest deleted: quest/m0/backport-audio-group-duration.md is removed now that its Goal shipped, with no archive copy (the repo's convention for a completed quest).
• Epic link removed: the quest/m0/README.md bullet for that quest is dropped, and no other file references it.

I re-verified the completion evidence rather than taking it from the body: #7290 is merged into release as d0cff5ac8b, release carries js/publish@0.5.5 (396fd3e67, merged as 5559eb337), and the published 0.5.5 tarball on npm (gitHead 5559eb337) contains groupDuration in both audio/encoder.d.ts and the encoder bundle, defaulting to Time.Milli(0). doc/lib/js/publish.md and both API reports were updated by the backport; js/publish/README.md does not document encoder props, so nothing is missing. git grep backport-audio-group-duration is empty, and quest check --base origin/main passes here (575 documents ok).

ℹ️ The recorded audio-group cap follow-up points the wrong way

The body's first follow-up asks to cap audio groups at MAX_GROUP_FRAMES / MAX_GROUP_CACHE_BYTES, but MAX_GROUP_FRAMES no longer exists in rs/moq-net, and quest/m2/unbounded-groups decides a group sheds its front at MAX_CACHE_BYTES instead of aborting. A 2.5 ms Opus frame therefore does not reach GroupTooLarge on main, so the premise is worth re-checking before the follow-up is filed as work.

Technical details

# Stale audio group cap follow-up

## Affected sites
- PR body `## Follow-ups`, first bullet
- `quest/m2/unbounded-groups/README.md:5` — `MAX_GROUP_FRAMES` is gone since #6993
- `rs/moq-net/src/model/group.rs:1572` — `GroupTooLarge` is returned only when the group cannot trim to fit

## Open questions for the human
- Is any of this still worth a quest, or does the m2 shedding work cover long audio groups?

  ^{｜ View workflow run ｜ Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏}

[kixelated]

Automated review by review (OpenAI)

Reviewed head: 88f135fb0ee16589dfec648a6862afc50e3bd49a.

Findings: No actionable defects found in the complete two-file diff. It removes only quest/m0/backport-audio-group-duration.md and its matching quest/m0/README.md entry; no runtime, API, or release code changes are introduced.

Completion evidence and fix status: The cleanup is supported by the release-line evidence, rather than the package version on main:

• #7290 merged the backport into release as d0cff5ac8b0955f873eb5822891fb44b87ecc070.
• #8025 merged the 0.5.5 cut as 5559eb337475a30da672433b3ad3a935dbd25691. At that exact commit, js/publish/package.json is 0.5.5 and js/publish/src/audio/encoder.ts contains the public groupDuration option and grouping implementation.
• The successful Release JS job explicitly logs + @moq/publish@0.5.5 followed by exit code 0.

No earlier published review by this reviewer was present to reconcile. The existing oversized-audio-group follow-up described in the PR is not fixed by this documentation cleanup and should remain separate.

Direction: No changes requested for this cleanup. Removing the finished quest is consistent with the verified backport and publication evidence.

Validation limits: GitHub-only static review of the full diff, release source, merged PRs, and workflow evidence. The exact-head Quest check passed; another Check job was still running when inspected. I did not run quest context, quest check, or runtime tests locally, nor independently download the npm tarball. This is a COMMENT review, not an approval or a claim that all CI has passed.