Repository navigation
fix: run CI once per push to main to avoid coverage branch race - #257
Merged
Merged
Conversation
Coverage report
This PR does not seem to contain any modification to coverable code. |
saraburns1
approved these changes
Oct 2, 2026
This was referenced Oct 5, 2026
farhan
added a commit
to farhan/django-wiki
that referenced
this pull request
Oct 6, 2026
release.yml calls ci.yml via workflow_call, so keeping a separate push: trigger in ci.yml would fire CI twice on every merge — both concurrent runs race to update the coverage data branch. Removing the push: block from ci.yml is sufficient; release.yml's workflow_call covers pushes to the default branch. Same race-condition bug fixed in openedx/platform-plugin-aspects#257. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
farhan
added a commit
to farhan/farhan-agent-skills
that referenced
this pull request
Oct 6, 2026
…0 and Test#445 Test#180 now verifies release.yml's push branch matches the repo's actual default branch (via gh repo view) and flags the mismatch with a concrete fix instruction. Repos like django-wiki use edx_release, not master, so the standard template would silently never release. Test#445 gains a note that a dead push trigger (wrong branch name) masks the double-run bug — both tests must be fixed together when the default branch is not master. References: - openedx/platform-plugin-aspects#257 (original double-run fix) - openedx/django-wiki#329 (first non-master default branch case) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This got broken in #253 . Release already calls ci.yml via workflow_call, so the separate push trigger ran the coverage action twice concurrently, and both runs pushed to the coverage data branch. Also add the missing coverage_comment step id so the PR comment artifact is actually uploaded.