Skip to content

fix(a11y): name icon-only buttons across product UI - #7975

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/control-fix-resource-action-labels
Sep 18, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/control-fix-resource-action-labels

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Icon-only buttons across chat, resource lists, knowledge dialogs, logs, workflow editing and previews, canvas controls, and the playground lacked accessible names. Add 65 aria-label attributes across 31 product files, covering every reported finding in the missing-button-name category.

Reuse existing tooltip and action text where available. State-dependent labels follow the existing UI state. Styles, markup structure, handlers, and visible text are unchanged; only accessible names and necessary formatting change.

This PR contains product changes only. The linter, its configuration and dependencies, and audit reports remain outside the PR.

Type of change

  • Bug fix: accessibility

Testing

  • External full-category audit: reported missing button names reduced from 65 to 0, with no new accessible-name analysis uncertainty.
  • Final external committed-diff linter: completed successfully, 0 introduced findings.
  • All 80 existing component tests passed across the affected app components and workflow renderer.
  • Type checks passed for apps/sim and packages/workflow-renderer.
  • Scoped Biome checks, API validation, and git diff --check passed.
  • Source AST comparison verified all existing accessible names and all other syntax are unchanged, apart from formatting and the 65 added attributes.

The category result covers the statically reported findings; pre-existing analyzer limitations remain. Redundant-style and duplicate-artwork findings belong to separate categories.

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 18, 2026 6:43pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the changes are limited to accurate accessible names and no actionable regression remains.

Summary

This PR adds accessible names to icon-only buttons across chat, resource management, knowledge, logs, workflow authoring, previews, canvas controls, and the workflow renderer.

  • Adds static and state-dependent aria-label attributes without changing handlers or application behavior.
  • Aligns accessible names with existing action text and tooltips.
  • Covers shared workflow and product surfaces without changing data, authorization, or persistence behavior.

Reviews (2) · Last reviewed commit: "fix(a11y): name remaining icon-only prod..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346 BillLeoutsakosvl346 changed the title fix(resource): add accessible names to bulk action buttons fix(a11y): name icon-only buttons across product UI Sep 18, 2026
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@waleedlatif1
waleedlatif1 merged commit b5d17aa into staging Sep 18, 2026
33 of 34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-resource-action-labels branch September 18, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants