Repository navigation
Conversation
Collaborator
|
Can one of the admins verify this patch?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified, and the reported artifact and hardware validation support the topology contracts and isolated IPC3 build paths.
No open issues 🎉
What changed in this PR
Forward-ports the Cherry Trail RT5677 IPC3 topology to main, preserving the tested stereo configuration and keeping IPC3 artifacts separate from IPC4.
Changes:
- Adds playback, capture, and deep-buffer support with two active slots in the four-slot SSP2 frame.
- Introduces reusable IPC3 pipeline and component definitions.
- Adds separate IPC3 build, deployment, and documentation support.
Paths below are relative to tools/topology/topology2/.
| File | Description |
|---|---|
README.md |
Documents IPC3 target registration and builds. |
production/tplg-targets-ipc3.cmake |
Registers the RT5677 target. |
production/CMakeLists.txt |
Builds IPC3 targets separately. |
platform/intel/cht-hw-config.conf |
Defines Cherry Trail SSP hardware attributes. |
include/pipelines/ipc3/volume-playback.conf |
Adds host volume playback. |
include/pipelines/ipc3/volume-dai-capture.conf |
Adds combined DAI-to-host capture. |
include/pipelines/ipc3/pipeline-common.conf |
Defines shared IPC3 pipeline attributes. |
include/pipelines/ipc3/mixer-volume-dai-playback.conf |
Adds mixed backend playback. |
include/components/widget-common.conf |
Adds optional IPC3 period-count tokens. |
include/components/ipc3/mixer.conf |
Defines the IPC3 mixer widget. |
include/components/buffer.conf |
Adds a Cherry Trail-compatible memory capability. |
CMakeLists.txt |
Separates IPC3 ABI generation and deployment. |
cht-rt5677.conf |
Defines board pipelines, PCM capabilities, and SSP2 configuration. |
Review effort: Balanced
MaurizioCasciano
force-pushed
the
submission/cht-rt5677-topology2-main-v1
branch
from
October 20, 2026 21:12
173d64b to
05d3e4c
Compare
Contributor
Author
kv2019i
reviewed
Oct 21, 2026
| @@ -7,9 +7,11 @@ add_custom_target(topologies2 ALL | |||
| # Create directory structure to be provided for deployment | |||
Collaborator
There was a problem hiding this comment.
@MaurizioCasciano Thanks for the new PR! Can you check the git commit message formatting? We use Linux kernel style formatting (wrap lines at 72 chars). Rest looks good.
Contributor
Author
There was a problem hiding this comment.
Fixed in 050cf8e. The commit message is now wrapped at 72 columns; the source tree is unchanged. Thanks!
Add topology2 support for generating and deploying IPC3 topology files alongside the existing IPC4 production set. Describe the Yoga Book RT5677 SSP2 playback, capture, low-latency and deep-buffer paths while preserving the Cherry Trail memory, scheduler, and hardware configuration required by the legacy IPC3 firmware. Keep the four-slot, 25-bit frame geometry but activate only slots 0 and 1 for the stereo stream. The generated topology is byte-identical to the artifact validated on a Lenovo Yoga Book YB1-X91L with PCM0 playback and capture in S16_LE, S24_LE and S32_LE at 48 kHz stereo, plus PCM1 deep-buffer playback. Signed-off-by: Maurizio Casciano <mauriziocasciano7@gmail.com>
MaurizioCasciano
force-pushed
the
submission/cht-rt5677-topology2-main-v1
branch
from
October 21, 2026 07:27
05d3e4c to
050cf8e
Compare
lgirdwood
approved these changes
Oct 21, 2026
Member
|
ipc3 and topology not tested by internal ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port #11129 to
main, superseding #11279.#11129 was merged into
stable-v2.15before the change reachedmain. Thisuses #11279 as the forward-port baseline and incorporates its review feedback:
new topology builds correctly from the initial commit;
verify-topology.pyaddition is left for a follow-up;it as a device-specific platform override; and
The topology keeps the four-slot, 25-bit SSP2 frame required by the machine
driver while activating slots 0 and 1 (
0x3) for the stereo stream.Validation:
cmake --build tools/build_tools --target topology2_prod_ipc3_sof-cht-rt5677 -- -j2sof-cht-rt5677.tplgSHA-256:746962d80115e3b9b0b2fbe44673b4e3acef5f06f7914baf235a5a652e8be09cYoga Book YB1-X91L with PCM0 playback/capture and PCM1 deep-buffer playback
Related: #11129, #11279