Repository navigation
refactor(stovepipe): Extract fact persistence - #1057
Open
prathshenoy wants to merge 2 commits into
Open
prathshenoy wants to merge 2 commits into
prathshenoy wants to merge 2 commits into
Conversation
1 task done
1 task done
Base automatically changed from
prath.shenoy/feat/stovepipe-project-issue-api
to
main
November 9, 2026 21:04
This was referenced Nov 9, 2026
## Summary **What**: - Expose both request-scoped attribution lookups through the service API. **Why**: - Let clients query the issues affecting a project and the projects affected by an issue. The read controller provides this behavior, but service bindings and wiring are needed to make it available through the API. ## Test Plan - [x] Add unit tests. ## Revert Plan - Revert this PR. It adds read-only APIs without changing schemas or stored data. ## Issue Links - [CODEM-632](https://linear.app/uber/issue/CODEM-632/projects-issues) ## Stack 1. #1046 1. #1047 1. #1048 1. #1049 1. #1053 1. #1054 1. #1051
## Summary **What**: - Extract shared validation-fact persistence without changing recording behavior. **Why**: - Allow repository-wide and project results to retain the same retry and ownership checks when their processing moves into separate stages. The existing recording stage owns this shared behavior, preventing another stage from reusing it directly. ## Test Plan - [x] Add unit tests. ## Revert Plan - Revert this PR. It reorganizes existing code without changing schemas or stored data. ## Issue Links - [CODEM-632](https://linear.app/uber/issue/CODEM-632/projects-issues)
prathshenoy
force-pushed
the
prath.shenoy/refactor/stovepipe-validation-facts
branch
from
November 10, 2026 15:42
160f64a to
0e595b8
Compare
prathshenoy
marked this pull request as ready for review
November 10, 2026 16:03
prathshenoy
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
November 10, 2026 16:03
prathshenoy
marked this pull request as draft
November 10, 2026 16:03
prathshenoy
marked this pull request as ready for review
November 10, 2026 16:03
1 task done
prathshenoy
added a commit
that referenced
this pull request
Nov 10, 2026
## Summary **What**: - Run project analysis after terminal build analysis and before repository recording. - Mark project analysis finished after project statuses and issue attribution are recorded, or processing is abandoned. **Why**: - Ensure attribution uses final build issues and repository recording receives the project results needed to distinguish partial failures from repository-wide failures. - Keep request summaries from reporting completion while project analysis is still running, and repair incomplete summary updates before handing off to repository recording. ## Test Plan - [x] Add unit tests. ## Revert Plan - Revert this PR after pausing intake and draining or reconciling pending project-analysis work, because the revert removes its consumers. ## Issue Links - [CODEM-632](https://linear.app/uber/issue/CODEM-632/projects-issues) ## Stack 1. #1057 1. #1066 1. #1058 1. #1062 1. #1065
prathshenoy
added a commit
that referenced
this pull request
Nov 10, 2026
## Summary **What**: - Run project analysis after terminal build analysis and before repository recording. - Mark project analysis finished after project statuses and issue attribution are recorded, or processing is abandoned. **Why**: - Ensure attribution uses final build issues and repository recording receives the project results needed to distinguish partial failures from repository-wide failures. - Keep request summaries from reporting completion while project analysis is still running, and repair incomplete summary updates before handing off to repository recording. ## Test Plan - [x] Add unit tests. ## Revert Plan - Revert this PR after pausing intake and draining or reconciling pending project-analysis work, because the revert removes its consumers. ## Issue Links - [CODEM-632](https://linear.app/uber/issue/CODEM-632/projects-issues) ## Stack 1. #1057 1. #1066 1. #1058 1. #1062 1. #1065
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What:
Why:
Test Plan
Revert Plan
Issue Links
Stack