Skip to content

feat(stovepipe): Share project completion tracking - #1064

Closed
prathshenoy wants to merge 1 commit into
prath.shenoy/feat/stovepipe-project-analysis-dlqfrom
prath.shenoy/feat/stovepipe-project-completion
Closed

prathshenoy wants to merge 1 commit into
prath.shenoy/feat/stovepipe-project-analysis-dlqfrom
prath.shenoy/feat/stovepipe-project-completion

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Folded into #1065.

Summary

What:

  • Include completed attribution and abandoned project analysis in the existing project-results completion timestamp.
  • Repair completion summaries before retrying the recording handoff.

Why:

  • Let request summaries show when shared project processing has finished, including work that stopped after exhausting retries. A retained completion event can outlive a failed summary update, so redeliveries must repair that projection before handing the request onward.

Test Plan

  • Add unit tests.

Revert Plan

  • Revert this PR. It reuses an existing summary field and requires no schema change.

Issue Links

Stack

  1. refactor(stovepipe): Extract fact persistence #1057
  2. feat(stovepipe): Define project analysis stage #1066
  3. feat(stovepipe): Implement project processing #1058
  4. feat(stovepipe): Recover project analysis failures #1062
  5. feat(stovepipe): Wire the project analysis stage #1065

@prathshenoy
prathshenoy added this pull request to stack #1059 November 9, 2026 22:25
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-completion branch from 012e3b0 to d79681a Compare November 10, 2026 15:42
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-analysis-dlq branch from 54a839f to fe2dab4 Compare November 10, 2026 16:27
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-completion branch from d79681a to a864897 Compare November 10, 2026 16:27
@prathshenoy
prathshenoy removed this pull request from stack #1059 November 10, 2026 16:28
@prathshenoy
prathshenoy added this pull request to stack #1067 November 10, 2026 16:44
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-analysis-dlq branch from fe2dab4 to fa73b86 Compare November 10, 2026 16:57
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-completion branch from a864897 to eaf84bc Compare November 10, 2026 16:57
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-analysis-dlq branch from fa73b86 to 523a469 Compare November 10, 2026 17:04
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-completion branch 2 times, most recently from 158117e to af4cad5 Compare November 10, 2026 17:08
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-analysis-dlq branch from 523a469 to de1a940 Compare November 10, 2026 17:08
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-completion branch from af4cad5 to d29ba95 Compare November 10, 2026 17:13
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-analysis-dlq branch 2 times, most recently from 2af200b to f05b629 Compare November 10, 2026 17:55
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-completion branch 2 times, most recently from 300cb84 to 977cc02 Compare November 10, 2026 21:12
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-analysis-dlq branch from f05b629 to 4f8666e Compare November 10, 2026 21:12
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-completion branch from 977cc02 to 2aa15b6 Compare November 10, 2026 21:17
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-analysis-dlq branch 2 times, most recently from bb4f01a to 6cca7cf Compare November 10, 2026 21:21
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-completion branch 2 times, most recently from 0715915 to b879696 Compare November 10, 2026 21:31
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-analysis-dlq branch from 6cca7cf to 5a4666b Compare November 10, 2026 21:31
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-completion branch from b879696 to ea5666e Compare November 10, 2026 21:42
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-analysis-dlq branch 2 times, most recently from 2374a6f to 5f851a0 Compare November 10, 2026 21:45
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-completion branch 2 times, most recently from 5de063c to 5cadc81 Compare November 10, 2026 21:52
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-analysis-dlq branch 2 times, most recently from ac0814a to e023c4e Compare November 10, 2026 22:15
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-completion branch from 5cadc81 to 6dbfad8 Compare November 10, 2026 22:15
**What**:
- Include completed attribution and abandoned project analysis in the existing project-results completion timestamp.
- Repair completion summaries before retrying the recording handoff.

**Why**:
- Let request summaries show when shared project processing has finished, including work that stopped after exhausting retries. A retained completion event can outlive a failed summary update, so redeliveries must repair that projection before handing the request onward.

- [x] Add unit tests.

- Revert this PR. It reuses an existing summary field and requires no schema change.

- [CODEM-632](https://linear.app/uber/issue/CODEM-632/projects-issues)
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-completion branch from 6dbfad8 to d5b9a0e Compare November 10, 2026 22:22
@prathshenoy
prathshenoy force-pushed the prath.shenoy/feat/stovepipe-project-analysis-dlq branch from e023c4e to d6d6ae3 Compare November 10, 2026 22:22
@prathshenoy
prathshenoy removed this pull request from stack #1067 November 10, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant