Repository navigation
feat(island): new notification options screen & compact view mode - #1303
Merged
sameerasw merged 6 commits intoOct 13, 2026
Merged
Conversation
isaacsa51
changed the title
…enter condensed line layout - Extract notification settings into a dedicated sub-page (`IslandNotificationSettingsUI`) and register `ISLAND_NOTIFICATIONS_FEATURE_ID`, replacing `IslandNotificationOptionsBottomSheet`. - Balance condensed line layout on both sides of the camera slot in `LineTemplate` and `IslandRoot`. - Update string resources and add unit tests in `CondensedLineTest` for centered camera positioning.
…act_line_peek # Conflicts: # app/src/main/java/com/sameerasw/essentials/island/model/IslandModels.kt # app/src/main/java/com/sameerasw/essentials/ui/features/display/IslandSettingsUI.kt
isaacsa51
marked this pull request as ready for review
October 12, 2026 01:59
Contributor
Author
|
ready for a review @sameerasw |
This was referenced Oct 12, 2026
sameerasw
approved these changes
Oct 13, 2026
sameerasw
left a comment
sameerasw
left a comment
Owner
There was a problem hiding this comment.
Thanks for your contributions <3
sameerasw
added a commit
that referenced
this pull request
Oct 13, 2026
## Description <!-- Describe what this PR changes and why. If it resolves an issue, link it here: e.g. Closes #123 --> Fix for a bug that the island was showing even with DND ON. Added on notification sections the ability to show the island popup following the DND mode or not. _current PR is dependant of #1303, so merging this first would break this PR_ ## Type of change - [x] Bug fix - [x] New feature - [ ] UI / visual update - [ ] Performance improvement - [ ] Refactoring / cleanup - [ ] Translations - [ ] Build / CI tooling ## UI changes <!-- Required if this PR changes or adds UI. Please attach screenshots or a screen recording. --> https://github.com/user-attachments/assets/a9a3c5de-3636-43c2-a0ce-4cf72956d315 ## Checklist Before submitting, please make sure: - [x] The base branch is set to `develop` (not `main`). - [x] The app builds cleanly locally with `./gradlew assembleDebug`. - [x] Unit tests pass with `./gradlew testDebugUnitTest`. - [x] You tested the changes on a device or emulator (including Shizuku or Root if applicable). - [x] New preferences use `SettingsRepository` for keys and getter/setter methods. - [x] New user-facing settings are registered in `FeatureRegistry.kt` for search indexing. - [x] New UI follows the design system in `ui/core/` (`RoundedCardContainer`, `IconToggleItem`, etc.). - [x] Strings are added to `res/values/strings.xml` and drawables use rounded variants (`R.drawable.rounded_*`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New screen instead of the bottom sheet for all notification options with a more complete description of each option.
On the Line peek now called Compact heads up, a new toggle between compact and full:
<appIcon> + cameraGap + <title>This can be access by tapping the settings icon on the notification What to show section with the option to re order it's priority.
Type of change
UI changes
Screen_recording_20261011_173956.mp4
Checklist
Before submitting, please make sure:
develop(notmain)../gradlew assembleDebug../gradlew testDebugUnitTest.SettingsRepositoryfor keys and getter/setter methods.FeatureRegistry.ktfor search indexing.ui/core/(RoundedCardContainer,IconToggleItem, etc.).res/values/strings.xmland drawables use rounded variants (R.drawable.rounded_*).