Skip to content

[ci] Inventory workflow jobs explicitly - #3576

Open
joshlf wants to merge 1 commit into
Gqofuqcjxqt64bw7di2snqyunualoi3htfrom
Ghrxpfppzzenc5ecwz3u273gd42e4psk7
Open

[ci] Inventory workflow jobs explicitly#3576
joshlf wants to merge 1 commit into
Gqofuqcjxqt64bw7di2snqyunualoi3htfrom
Ghrxpfppzzenc5ecwz3u273gd42e4psk7

Conversation

@joshlf

@joshlf joshlf commented Aug 25, 2026

Copy link
Copy Markdown
Member

Add a narrow scanner for every lower-case YAML workflow file and its
canonical top-level job IDs. Compare that live inventory with a sorted,
reviewed registry which assigns each job a plain-language role.

Reject quoted or anchored job declarations, duplicate jobs, unfamiliar
jobs keys, case-variant YAML extensions, unsorted registry rows, unknown
roles, and any missing or unreviewed job. Continue using
action-validator for the complete YAML and GitHub Actions schema rather
than implementing another YAML interpreter in zc.

This commit only establishes the handwritten-workflow inventory
boundary. Its crate-private entry point is temporarily allowed to be
unused outside tests; the all-input boundary removes that allowance when
it begins calling the audit. Later checks use the roles to constrain
generated data and keep required static validation and aggregation jobs
visible.

Tests: CARGO_NET_OFFLINE=true ./ci/check_tools.sh
Tests: ./ci/check_fmt.sh

Authored by an agent, posting via joshlf's account


Latest Update: v12 — Compare vs v11

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Ghrxpfppzzenc5ecwz3u273gd42e4psk7 && git checkout -b pr-Ghrxpfppzzenc5ecwz3u273gd42e4psk7 FETCH_HEAD

Checkout

git fetch origin refs/heads/Ghrxpfppzzenc5ecwz3u273gd42e4psk7 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Ghrxpfppzzenc5ecwz3u273gd42e4psk7 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Ghrxpfppzzenc5ecwz3u273gd42e4psk7

Stacked PRs enabled by GHerrit.

@codecov-commenter

codecov-commenter commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (7710b76) to head (cc02374).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           Gqofuqcjxqt64bw7di2snqyunualoi3ht    #3576   +/-   ##
==================================================================
  Coverage                              91.85%   91.85%           
==================================================================
  Files                                     20       20           
  Lines                                   6093     6093           
==================================================================
  Hits                                    5597     5597           
  Misses                                   496      496           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

joshlf commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 1b5b56e0fb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

joshlf commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 67fc58e27e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshlf
joshlf force-pushed the Ghrxpfppzzenc5ecwz3u273gd42e4psk7 branch from 67fc58e to f277ad7 Compare August 26, 2026 01:28
@joshlf
joshlf force-pushed the Gqofuqcjxqt64bw7di2snqyunualoi3ht branch from 0be1058 to dabba7d Compare August 26, 2026 09:58
@joshlf
joshlf force-pushed the Ghrxpfppzzenc5ecwz3u273gd42e4psk7 branch from f277ad7 to 453c9c9 Compare August 26, 2026 09:58
@joshlf

joshlf commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 453c9c957b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Add a narrow scanner for every lower-case YAML workflow file and its
canonical top-level job IDs. Compare that live inventory with a sorted,
reviewed registry which assigns each job a plain-language role.

Reject quoted or anchored job declarations, duplicate jobs, unfamiliar
jobs keys, case-variant YAML extensions, unsorted registry rows, unknown
roles, and any missing or unreviewed job. Continue using
action-validator for the complete YAML and GitHub Actions schema rather
than implementing another YAML interpreter in zc.

This commit only establishes the handwritten-workflow inventory
boundary. Its crate-private entry point is temporarily allowed to be
unused outside tests; the all-input boundary removes that allowance when
it begins calling the audit. Later checks use the roles to constrain
generated data and keep required static validation and aggregation jobs
visible.

Tests: CARGO_NET_OFFLINE=true ./ci/check_tools.sh
Tests: ./ci/check_fmt.sh

*Authored by an agent, posting via joshlf's account*

gherrit-pr-id: Ghrxpfppzzenc5ecwz3u273gd42e4psk7
@joshlf
joshlf force-pushed the Ghrxpfppzzenc5ecwz3u273gd42e4psk7 branch from 453c9c9 to cc02374 Compare August 26, 2026 11:31
@joshlf

joshlf commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants