Skip to content

[ci] Make typed workflow bridges fail closed - #3592

Open
joshlf wants to merge 1 commit into
Gquoamyb32c2czjlzvvkel27kkqeg2tidfrom
Gg5onzlaf6nsoqoubbjg43tdiuxvvjrbc
Open

[ci] Make typed workflow bridges fail closed#3592
joshlf wants to merge 1 commit into
Gquoamyb32c2czjlzvvkel27kkqeg2tidfrom
Gg5onzlaf6nsoqoubbjg43tdiuxvvjrbc

Conversation

@joshlf

@joshlf joshlf commented Aug 25, 2026

Copy link
Copy Markdown
Member

Derive Miri job eligibility from the projected matrix instead of
repeating the event policy in workflow YAML. Publish the same gate to
the required-check aggregate so policy changes cannot select work that
the workflow silently skips.

Run the planner with an absolute privileged Bash, neutralized
startup controls, and a command-local fixed PATH. Invoke an explicit
child Bash so the cargo wrapper cannot select an ambient interpreter.

Run typed cells with absolute Docker, a fixed /bin/bash entrypoint,
privileged no-startup arguments, and an option terminator. Use absolute
jq in the final gate. These bridges now fail if PATH, image startup
state, or Bash startup state attempts to replace their commands.

This changes transport and eligibility wiring, not selected
coverage: pull requests still run 60 build and zero Miri cells. Full
events still run 182 build cells and 64 Miri cells.

Tests: offline zc tests
Tests: ci/check_actions.sh
Tests: cargo fmt --check
Tests: git diff --check

Authored by an agent, posting via joshlf's account


Latest Update: v9 — Compare vs v8

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gg5onzlaf6nsoqoubbjg43tdiuxvvjrbc && git checkout -b pr-Gg5onzlaf6nsoqoubbjg43tdiuxvvjrbc FETCH_HEAD

Checkout

git fetch origin refs/heads/Gg5onzlaf6nsoqoubbjg43tdiuxvvjrbc && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gg5onzlaf6nsoqoubbjg43tdiuxvvjrbc && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gg5onzlaf6nsoqoubbjg43tdiuxvvjrbc

Stacked PRs enabled by GHerrit.

joshlf commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: a565eff878

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshlf
joshlf force-pushed the Gg5onzlaf6nsoqoubbjg43tdiuxvvjrbc branch from a565eff to 7de4caa Compare August 25, 2026 22:48
@joshlf
joshlf force-pushed the Gquoamyb32c2czjlzvvkel27kkqeg2tid branch from 4f0c3e7 to 2a757e8 Compare August 25, 2026 22:48
@codecov-commenter

codecov-commenter commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (af342b3) to head (cc272d2).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           Gquoamyb32c2czjlzvvkel27kkqeg2tid    #3592   +/-   ##
==================================================================
  Coverage                              91.85%   91.85%           
==================================================================
  Files                                     20       20           
  Lines                                   6093     6093           
==================================================================
  Hits                                    5597     5597           
  Misses                                   496      496           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

joshlf commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: c86ea119f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Derive Miri job eligibility from the projected matrix instead of
repeating the event policy in workflow YAML. Publish the same gate to
the required-check aggregate so policy changes cannot select work that
the workflow silently skips.

Run the planner with an absolute privileged Bash, neutralized
startup controls, and a command-local fixed PATH. Invoke an explicit
child Bash so the cargo wrapper cannot select an ambient interpreter.

Run typed cells with absolute Docker, a fixed /bin/bash entrypoint,
privileged no-startup arguments, and an option terminator. Use absolute
jq in the final gate. These bridges now fail if PATH, image startup
state, or Bash startup state attempts to replace their commands.

This changes transport and eligibility wiring, not selected
coverage: pull requests still run 60 build and zero Miri cells. Full
events still run 182 build cells and 64 Miri cells.

Tests: offline zc tests
Tests: ci/check_actions.sh
Tests: cargo fmt --check
Tests: git diff --check

*Authored by an agent, posting via joshlf's account*

gherrit-pr-id: Gg5onzlaf6nsoqoubbjg43tdiuxvvjrbc
@joshlf
joshlf force-pushed the Gg5onzlaf6nsoqoubbjg43tdiuxvvjrbc branch from c86ea11 to cc272d2 Compare August 26, 2026 01:28
@joshlf
joshlf force-pushed the Gquoamyb32c2czjlzvvkel27kkqeg2tid branch from b0f94a4 to af342b3 Compare August 26, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants