[ci] Read frozen CI baselines strictly - #3577
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Ghrxpfppzzenc5ecwz3u273gd42e4psk7 #3577 +/- ##
====================================================================
Coverage ? 91.85%
====================================================================
Files ? 20
Lines ? 6093
Branches ? 0
====================================================================
Hits ? 5597
Misses ? 496
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2fdec85 to
4864e15
Compare
ca89a5d to
1b5b56e
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
4864e15 to
b49d72d
Compare
1b5b56e to
67fc58e
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Add typed, data-only readers for the eight files which record legacy CI behavior. Require exact headers, field counts, row order, identifiers, paths, counts, hashes, command forms, action references, and canonical JSON. Reject invalid UTF-8, control characters, duplicate rows, and manifest counts which disagree with the parsed data. Keep parsed fields private and expose validated constructors so future plans cannot bypass the same invariants when comparing exact sets. Report missing and extra work separately and in deterministic order. This reader deliberately does not parse workflow YAML or regenerate the baseline. The checked-in files remain independent review evidence from the old workflow rather than an expectation produced by the new planner. Tests: standalone warning-free compilation; 12 baseline mutation tests. *Authored by an agent, posting via joshlf's account* gherrit-pr-id: Gt4itljw3xh6tci2mjqj4z245i6pwle2i
67fc58e to
f277ad7
Compare
b49d72d to
55a8694
Compare
2 participants
Add typed, data-only readers for the eight files which record legacy CI
behavior. Require exact headers, field counts, row order, identifiers,
paths, counts, hashes, command forms, action references, and canonical
JSON. Reject invalid UTF-8, control characters, duplicate rows, and
manifest counts which disagree with the parsed data.
Keep parsed fields private and expose validated constructors so future
plans cannot bypass the same invariants when comparing exact sets.
Report missing and extra work separately and in deterministic order.
This reader deliberately does not parse workflow YAML or regenerate the
baseline. The checked-in files remain independent review evidence from
the old workflow rather than an expectation produced by the new planner.
Tests: standalone warning-free compilation; 12 baseline mutation tests.
Authored by an agent, posting via joshlf's account
Latest Update: v9 — Compare vs v8
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gt4itljw3xh6tci2mjqj4z245i6pwle2i && git checkout -b pr-Gt4itljw3xh6tci2mjqj4z245i6pwle2i FETCH_HEADCheckout
git fetch origin refs/heads/Gt4itljw3xh6tci2mjqj4z245i6pwle2i && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gt4itljw3xh6tci2mjqj4z245i6pwle2i && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.