Skip to content

[ci] Validate all inputs before CI planning - #3579

Open
joshlf wants to merge 1 commit into
Gocqawbn3p3zj7xyfo7etk6vo4633r3tnfrom
Gsizgstaatljzyuwyc4tp4ha6krvibz64
Open

[ci] Validate all inputs before CI planning#3579
joshlf wants to merge 1 commit into
Gocqawbn3p3zj7xyfo7etk6vo4633r3tnfrom
Gsizgstaatljzyuwyc4tp4ha6krvibz64

Conversation

@joshlf

@joshlf joshlf commented Aug 25, 2026

Copy link
Copy Markdown
Member

Add one loading boundary which reads the typed policy, audits live Cargo
metadata and repository files, inventories every workflow job, and
strictly parses the frozen legacy baseline. Return planning inputs only
after every layer succeeds. Wiring the workflow audit here also removes
the temporary unused-code allowance from its introductory commit.

This keeps future planners from depending on call order or accidentally
skipping a validation pass. It also keeps the policy-owned baseline
paths in one place rather than repeating their coordination in each
consumer.

Tests: CARGO_NET_OFFLINE=true ./ci/check_tools.sh
Tests: ./ci/check_fmt.sh

Authored by an agent, posting via joshlf's account


Latest Update: v9 — Compare vs v8

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gsizgstaatljzyuwyc4tp4ha6krvibz64 && git checkout -b pr-Gsizgstaatljzyuwyc4tp4ha6krvibz64 FETCH_HEAD

Checkout

git fetch origin refs/heads/Gsizgstaatljzyuwyc4tp4ha6krvibz64 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gsizgstaatljzyuwyc4tp4ha6krvibz64 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gsizgstaatljzyuwyc4tp4ha6krvibz64

Stacked PRs enabled by GHerrit.

@codecov-commenter

codecov-commenter commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (Gocqawbn3p3zj7xyfo7etk6vo4633r3tn@fded6e0). Learn more about missing BASE report.

Additional details and impacted files
@@                         Coverage Diff                          @@
##             Gocqawbn3p3zj7xyfo7etk6vo4633r3tn    #3579   +/-   ##
====================================================================
  Coverage                                     ?   91.85%           
====================================================================
  Files                                        ?       20           
  Lines                                        ?     6093           
  Branches                                     ?        0           
====================================================================
  Hits                                         ?     5597           
  Misses                                       ?      496           
  Partials                                     ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

joshlf commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 16d8463814

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

joshlf commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: aeefea68ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Add one loading boundary which reads the typed policy, audits live Cargo
metadata and repository files, inventories every workflow job, and
strictly parses the frozen legacy baseline. Return planning inputs only
after every layer succeeds. Wiring the workflow audit here also removes
the temporary unused-code allowance from its introductory commit.

This keeps future planners from depending on call order or accidentally
skipping a validation pass. It also keeps the policy-owned baseline
paths in one place rather than repeating their coordination in each
consumer.

Tests: CARGO_NET_OFFLINE=true ./ci/check_tools.sh
Tests: ./ci/check_fmt.sh

*Authored by an agent, posting via joshlf's account*

gherrit-pr-id: Gsizgstaatljzyuwyc4tp4ha6krvibz64
@joshlf
joshlf force-pushed the Gocqawbn3p3zj7xyfo7etk6vo4633r3tn branch from 77f85fe to fded6e0 Compare August 26, 2026 01:28
@joshlf
joshlf force-pushed the Gsizgstaatljzyuwyc4tp4ha6krvibz64 branch from aeefea6 to a008f12 Compare August 26, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants