[ci] Audit typed jobs into the required check - #3595
Conversation
4ebd94a to
b221e68
Compare
3143da8 to
89b8771
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
08726ef to
762a0dc
Compare
b221e68 to
4d1e30f
Compare
762a0dc to
ecf9460
Compare
4d1e30f to
d0a694d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gqs4rhblhbsqga3glvc6tfjnakpdspo3b #3595 +/- ##
====================================================================
Coverage ? 91.85%
====================================================================
Files ? 20
Lines ? 6093
Branches ? 0
====================================================================
Hits ? 5597
Misses ? 496
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
d0a694d to
97c42a7
Compare
ecf9460 to
456f2d4
Compare
Require all-jobs-succeed to retain its exact top-level shape, externally configured display name, empty permissions, hosted runner, always-run condition, and minimum direct path from plan_ci, build_test, miri, semver, and the job dependency audit. Audit the exact ordered cancellation guard and require all five planner outputs to be present before final aggregation. Treat Miri and semver as the only optional jobs: each may be skipped exactly when its checked enable output is false and must succeed when enabled. Match the total skipped dependency count to those disabled jobs so no unrelated skip can pass. Reject extra privileged steps, and require exact environments, custom Bash, and the absolute jq run block. Normalize the aggregate YAML indentation and document that its display name must stay coordinated with the external branch-protection or ruleset setting. Tests: offline zc tests Tests: zc clippy with warnings denied Tests: ci/check_actions.sh Tests: cargo.sh ci audit Tests: ci/check_fmt.sh Tests: git diff --check *Authored by an agent, posting via joshlf's account* gherrit-pr-id: Gnouzrlnq3bnxeg72jfe7d3xq6jymqqcf
97c42a7 to
4a612ad
Compare
456f2d4 to
7a4ccf8
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head. Treat earlier reviews of older commits as stale. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Require all-jobs-succeed to retain its exact top-level shape,
externally configured display name, empty permissions, hosted runner,
always-run condition, and minimum direct path from plan_ci, build_test,
miri, semver, and the job dependency audit.
Audit the exact ordered cancellation guard and require all five planner
outputs to be present before final aggregation. Treat Miri and semver as
the only optional jobs: each may be skipped exactly when its checked
enable output is false and must succeed when enabled. Match the total
skipped dependency count to those disabled jobs so no unrelated skip can
pass. Reject extra privileged steps, and require exact environments,
custom Bash, and the absolute jq run block.
Normalize the aggregate YAML indentation and document that its
display name must stay coordinated with the external branch-protection
or ruleset setting.
Tests: offline zc tests
Tests: zc clippy with warnings denied
Tests: ci/check_actions.sh
Tests: cargo.sh ci audit
Tests: ci/check_fmt.sh
Tests: git diff --check
Authored by an agent, posting via joshlf's account
Latest Update: v9 — Compare vs v8
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gnouzrlnq3bnxeg72jfe7d3xq6jymqqcf && git checkout -b pr-Gnouzrlnq3bnxeg72jfe7d3xq6jymqqcf FETCH_HEADCheckout
git fetch origin refs/heads/Gnouzrlnq3bnxeg72jfe7d3xq6jymqqcf && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gnouzrlnq3bnxeg72jfe7d3xq6jymqqcf && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.